RFR: 8320449: ECDHKeyAgreement should validate parameters before using them [v3]

[Sean Mullan]

On Mon, 15 Jan 2024 03:37:45 GMT, John Jiang <jjiang at openjdk.org> wrote:

>> ECDHKeyAgreement should validate the parameters before assigning them to the fields.
>
> John Jiang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Not use JUnit

test/jdk/sun/security/ec/ECDHKeyAgreementParamValidation.java line 72:

> 70:                 IllegalStateException.class,
> 71:                 ()->ka.doPhase(kp.getPublic(), true));
> 72:     }

How about also calling `generateSecret` and checking for `IllegalStateException`?

test/jdk/sun/security/ec/ECDHKeyAgreementParamValidation.java line 92:

> 90:                 () -> ka.doPhase(kpP384.getPublic(), true));
> 91: 
> 92:         // Should not generate share key with SECP256R1 private key and SECP384R1 public key

Typo: s/share/shared/

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17373#discussion_r1453442848
PR Review Comment: https://git.openjdk.org/jdk/pull/17373#discussion_r1453443829