RFR: JDK-8322100: Fix GCMIncrementByte4 & GCMIncrementDirect4, and increase overlap testing

Jamil Nimeh jnimeh at openjdk.org
Wed Jan 17 01:43:50 UTC 2024


On Thu, 11 Jan 2024 03:26:03 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

> Hi,
> 
> I need a review of a few simple test changes.  This fixes a failure with two manually run AES/GCM tests that depended on another test that changed with [JDK-8318756](https://bugs.openjdk.org/browse/JDK-8318756).  It also adds testing for overlapping buffers that AES/GCM has, but CC20P1305 needs after JDK-8318756 was included.
> 
> After the change, manual testing of GCMIncrementByte4 and GCMIncrementDirect4 were successfully and automated tests passed as well.
> 
> thanks
> 
> Tony

LGTM

-------------

Marked as reviewed by jnimeh (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17362#pullrequestreview-1826243669



More information about the security-dev mailing list