RFR: 8320219: Actually resolve issues with goto labels in sspi [v7]
Weijun Wang
weijun at openjdk.org
Fri Jan 19 18:46:29 UTC 2024
On Fri, 19 Jan 2024 01:37:18 GMT, Julian Waters <jwaters at openjdk.org> wrote:
>> src/java.security.jgss/windows/native/libsspi_bridge/sspi.cpp line 422:
>>
>>> 420: gss_name_struct* name = new gss_name_struct;
>>> 421: if (name == nullptr) {
>>> 422: goto err;
>>
>> Go back? This looks more evil to me. Can we just `delete` and `return` here?
>
> I left it in there since it seemed inconsistent to have one site return while the rest used goto, I can replace it if needed
My understanding is that this is already after the `execution` label so it's a different.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16682#discussion_r1459391349
More information about the security-dev
mailing list