RFR: 8320219: Actually resolve issues with goto labels in sspi [v9]

[Weijun Wang]

On Fri, 19 Jan 2024 01:57:40 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> I regret not actually addressing the issues with the goto labels in https://github.com/openjdk/jdk/pull/15996, where initialization of locals in sspi were jumped over by gotos to a certain label. I changed the initializations into split declarations and assignments in https://github.com/openjdk/jdk/pull/15996, but this is simply a hack and does not address the real issue of gotos jumping over locals. I've as such fixed the issues with them properly this time, by simply deleting the labels and duplicating the code where they're used. As mentioned, this unfortunately does increase duplicate code, but is the cleanest solution I could come up with for the labels
>
> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
> 
>   std:: qualifier sspi.cpp

I re-read the new fix. The way you move the error block works because in some cases it *happens* that the jump does not go across a variable declaration. When it does not work you either have to jump backwards or duplicate codes. This is not worth doing.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16682#issuecomment-1904170781