RFR: 8320362: Load anchor certificates from Keychain keystore [v4]

Weijun Wang weijun at openjdk.org
Wed Jan 31 15:11:06 UTC 2024


On Thu, 25 Jan 2024 22:01:48 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

>> Please review the proposed fix.
>> 
>> The patch loads system root certificates from the MacOS Keychain with TrustSettings.
>> It allows to build a trusted certificate path using the MacOS Keychain store only.
>
> Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Reuse code from addCertificatesToKeystore

Great! The change looks good. Can you manage to add a test? Maybe try to load both store types. Make sure they have different contents and not empty (?).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16722#issuecomment-1919295342



More information about the security-dev mailing list