RFR: 8333364: Minor cleanup could be done in com.sun.crypto.provider [v4]

[Kevin Driver]

On Fri, 14 Jun 2024 13:11:06 GMT, Mark Powers <mpowers at openjdk.org> wrote:

>> https://bugs.openjdk.org/browse/JDK-8333364
>
> Mark Powers has updated the pull request incrementally with one additional commit since the last revision:
> 
>   move variables to above try block

src/java.base/share/classes/com/sun/crypto/provider/AESKeyWrap.java line 33:

> 31: import javax.crypto.IllegalBlockSizeException;
> 32: 
> 33: import static com.sun.crypto.provider.KWUtil.*;

One more wild-card import, as long as you're removing them.

src/java.base/share/classes/com/sun/crypto/provider/AESKeyWrapPadded.java line 34:

> 32: import javax.crypto.IllegalBlockSizeException;
> 33: 
> 34: import static com.sun.crypto.provider.KWUtil.*;

One more wild-card import, as long as you're removing them.

src/java.base/share/classes/com/sun/crypto/provider/ChaCha20Cipher.java line 950:

> 948:      * set here.
> 949:      *
> 950:      * @throws IllegalArgumentException if the key or nonce are not in

Can `IllegalArgumentException` no longer be thrown? I see that you removed `InvalidKeyException` from the throws in the method signature, but I'm not sure if you meant to remove this one from the javadoc as well?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19535#discussion_r1662907789
PR Review Comment: https://git.openjdk.org/jdk/pull/19535#discussion_r1662908258
PR Review Comment: https://git.openjdk.org/jdk/pull/19535#discussion_r1662910680