RFR: 8333364: Minor cleanup could be done in com.sun.crypto.provider [v4]

Kevin Driver kdriver at openjdk.org
Tue Jul 2 17:40:24 UTC 2024


On Fri, 14 Jun 2024 13:11:06 GMT, Mark Powers <mpowers at openjdk.org> wrote:

>> https://bugs.openjdk.org/browse/JDK-8333364
>
> Mark Powers has updated the pull request incrementally with one additional commit since the last revision:
> 
>   move variables to above try block

src/java.base/share/classes/com/sun/crypto/provider/DHKEM.java line 30:

> 28: import java.io.IOException;
> 29: import java.math.BigInteger;
> 30: import java.security.*;

Wild-card import, as long as you're removing them.

src/java.base/share/classes/com/sun/crypto/provider/DHKEM.java line 38:

> 36: import java.util.Arrays;
> 37: import java.util.Objects;
> 38: import javax.crypto.*;

Wild-card import, as long as you're removing them.

src/java.base/share/classes/com/sun/crypto/provider/DHKEM.java line 43:

> 41: import sun.security.jca.JCAUtil;
> 42: import sun.security.ssl.HKDF;
> 43: import sun.security.util.*;

Wild-card import, as long as you're removing them.

src/java.base/share/classes/com/sun/crypto/provider/DHKeyAgreement.java line 29:

> 27: 
> 28: import java.math.BigInteger;
> 29: import java.security.*;

Wild-card import, as long as you're removing them.

src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java line 32:

> 30: import java.nio.ByteBuffer;
> 31: import java.nio.ByteOrder;
> 32: import java.security.*;

Wild-card import, as long as you're removing them.

src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java line 36:

> 34: import java.security.spec.InvalidParameterSpecException;
> 35: import java.util.Arrays;
> 36: import javax.crypto.*;

Wild-card import, as long as you're removing them.

src/java.base/share/classes/com/sun/crypto/provider/HmacCore.java line 29:

> 27: 
> 28: import java.nio.ByteBuffer;
> 29: import java.security.*;

Wild-card import, as long as you're removing them.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19535#discussion_r1662923348
PR Review Comment: https://git.openjdk.org/jdk/pull/19535#discussion_r1662923241
PR Review Comment: https://git.openjdk.org/jdk/pull/19535#discussion_r1662923507
PR Review Comment: https://git.openjdk.org/jdk/pull/19535#discussion_r1662923704
PR Review Comment: https://git.openjdk.org/jdk/pull/19535#discussion_r1662924462
PR Review Comment: https://git.openjdk.org/jdk/pull/19535#discussion_r1662924547
PR Review Comment: https://git.openjdk.org/jdk/pull/19535#discussion_r1662924667



More information about the security-dev mailing list