RFR: 8333317: Test sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java failed with: Invalid ECDH ServerKeyExchange signature
Jaikiran Pai
jpai at openjdk.org
Mon Jul 15 13:00:54 UTC 2024
On Mon, 24 Jun 2024 12:07:49 GMT, Matthew Donovan <mdonovan at openjdk.org> wrote:
> In this PR, I updated the version of NSS to 3.101 and removed the test from the ProblemList for all platforms but linux-ppc64le (that bug is still outstanding.)
>
> I also updated the skipTest logic in TestDSAKeyLength.java. Prior to my change, it compared the version numbers as double values but that doesn't work when version 3.101 is later (i.e., greater) than 3.14.
test/jdk/sun/security/pkcs11/Signature/TestDSAKeyLength.java line 2:
> 1: /*
> 2: * Copyright (c) 2013, 20224, Oracle and/or its affiliates. All rights reserved.
Not an official review of the PR, since I don't have the necessary background of this library or the code. But this line has a typo in the copyright year - it should have been `2024`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19855#discussion_r1677788659
More information about the security-dev
mailing list