RFR: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect [v5]
Bradford Wetmore
wetmore at openjdk.org
Wed Jul 17 21:52:32 UTC 2024
On Wed, 17 Jul 2024 15:42:11 GMT, Fernando Guallini <fguallini at openjdk.org> wrote:
>> As highlighted in the bug description, The test **security/Security/SynchronizedAccess.java** have some issues:
>>
>> 1. it needs to implement the sigalg, otherwise it throws java.security.NoSuchAlgorithmException . Even though it does not fail as it catches the exception, it never reaches the removeProvider loop. Also, adding an extra assertion to verify the local providers were actually removed.
>> 2. It is reassigning the **provs** variable with Security.getProviders(). This will start adding/removing some of the system providers, in addition to the local providers, which it is not the test intent.
>> 3. Adding othervm flag to run in isolation.
>>
>> Test runs in tier2
>
> Fernando Guallini has updated the pull request incrementally with one additional commit since the last revision:
>
> applied suggested patch
LGTM
-------------
Marked as reviewed by wetmore (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19480#pullrequestreview-2184144771
More information about the security-dev
mailing list