RFR: 8298420: PEM API: Implementation (Preview) [v2]

Sibabrata Sahoo ssahoo at openjdk.org
Mon Jul 29 04:41:33 UTC 2024


On Fri, 26 Jul 2024 03:58:11 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

>> Hi all,
>> 
>> I need a code review of the PEM API.  Privacy-Enhanced Mail (PEM) is a format for encoding and decoding cryptographic keys and certificates.  It will be integrated into JDK24 as a Preview Feature.  Preview features does not permanently define the API and it is subject to change in future releases until it is finalized.
>> 
>> Details about this change can be seen at [PEM API JEP](https://bugs.openjdk.org/browse/JDK-8300911).
>> 
>> Thanks
>> 
>> Tony
>
> Anthony Scarpino has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - bad test check
>  - internal PEMRecord optimization

src/java.base/share/classes/java/security/AsymmetricKey.java line 35:

> 33:  * a private key.
> 34:  *
> 35:  * @since 22

Should this 24?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r1694532326



More information about the security-dev mailing list