RFR: 8298420: PEM API: Implementation (Preview) [v2]

[Anthony Scarpino]

On Thu, 25 Jul 2024 20:06:18 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Anthony Scarpino has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - bad test check
>>  - internal PEMRecord optimization
>
> src/java.base/share/classes/sun/security/util/Pem.java line 136:
> 
>> 134:     public static ObjectIdentifier getPBEID(String algorithm) {
>> 135:         try {
>> 136:             if (algorithm.contains("AES")) {
> 
> Is this check reliable?

It has been reliable, though I now see that the PBE1 spec does support AES, but SunJCE doesn't.  That's unfortunate as I wouldn't have made that assumption.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r1695845328