RFR: 8298420: PEM API: Implementation (Preview) [v2]

Tue Jul 30 21:00:34 UTC 2024

On Mon, 29 Jul 2024 23:01:49 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> I do not understand this comment.  Have two copies of this method in PKCS8EKS and X509EKS?  This sounds like duplicate code to me.
>
> Maybe this is a similar opinion on the line endings. I don't want to be too flexible too soon.

I don't see a downside of being flexible here.  If there algorithm fails, it leaves the name as is.  As we discussed elsewhere, the worst that could happen is it sets it to an OID string.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r1697581108