RFR: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect [v2]
Fernando Guallini
fguallini at openjdk.org
Mon Jun 3 09:54:16 UTC 2024
> As highlighted in the bug description, The test **security/Security/SynchronizedAccess.java** have some issues:
>
> 1. it needs to implement the sigalg, otherwise it throws java.security.NoSuchAlgorithmException . Even though it does not fail as it catches the exception, it never reaches the removeProvider loop. Also, adding an extra assertion to verify the local providers were actually removed.
> 2. It is reassigning the **provs** variable with Security.getProviders(). This will start adding/removing some of the system providers, in addition to the local providers, which it is not the test intent.
> 3. Adding othervm flag to run in isolation.
>
> Test runs in tier2
Fernando Guallini has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
- Merge branch 'openjdk:master' into JDK-8028127
- Merge branch 'openjdk:master' into JDK-8028127
- Regtest java/security/Security/SynchronizedAccess.java is incorrect.
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/19480/files
- new: https://git.openjdk.org/jdk/pull/19480/files/61b56f0a..1549cc59
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=19480&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=19480&range=00-01
Stats: 5703 lines in 200 files changed: 3363 ins; 1647 del; 693 mod
Patch: https://git.openjdk.org/jdk/pull/19480.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/19480/head:pull/19480
PR: https://git.openjdk.org/jdk/pull/19480
More information about the security-dev
mailing list