RFR: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect [v3]

Fernando Guallini fguallini at openjdk.org
Thu Jun 6 13:13:00 UTC 2024


> As highlighted in the bug description, The test **security/Security/SynchronizedAccess.java** have some issues:
> 
> 1. it needs to implement the sigalg, otherwise it throws java.security.NoSuchAlgorithmException . Even though it does not fail as it catches the exception, it never reaches the removeProvider loop. Also, adding an extra assertion to verify the local providers were actually removed.
> 2. It is reassigning the **provs** variable with Security.getProviders(). This will start adding/removing some of the system providers, in addition to the local providers, which it is not the test intent.
> 3. Adding othervm flag to run in isolation.
> 
> Test runs in tier2

Fernando Guallini has updated the pull request incrementally with one additional commit since the last revision:

  added brackets, and refactor a comment and an exception message

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19480/files
  - new: https://git.openjdk.org/jdk/pull/19480/files/1549cc59..3502c27a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19480&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19480&range=01-02

  Stats: 11 lines in 1 file changed: 4 ins; 0 del; 7 mod
  Patch: https://git.openjdk.org/jdk/pull/19480.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19480/head:pull/19480

PR: https://git.openjdk.org/jdk/pull/19480



More information about the security-dev mailing list