RFR: 8326705: Test CertMsgCheck.java fails to find alert certificate_required

Mark Powers mpowers at openjdk.org
Thu Jun 6 14:30:49 UTC 2024


On Wed, 5 Jun 2024 23:48:56 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

>> test/jdk/javax/net/ssl/templates/TLSBase.java line 101:
>> 
>>> 99:         if (!empty) {
>>> 100:             fis = new FileInputStream(System.getProperty("test.src", "./") +
>>> 101:                 "/" + pathToStores + "/" + keyStoreFile);
>> 
>> My Java style guide says to break before the operator.
>
> I have never heard that.  I have always ended with a plus and I believe everyone else does too if I'm not mistaken.

https://cr.openjdk.org/~alundblad/styleguide/index-v6.html#toc-constants

Probably showed up in a code review comment from someone.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19553#discussion_r1629664247



More information about the security-dev mailing list