RFR: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect [v4]
Fernando Guallini
fguallini at openjdk.org
Thu Jun 6 15:45:54 UTC 2024
> As highlighted in the bug description, The test **security/Security/SynchronizedAccess.java** have some issues:
>
> 1. it needs to implement the sigalg, otherwise it throws java.security.NoSuchAlgorithmException . Even though it does not fail as it catches the exception, it never reaches the removeProvider loop. Also, adding an extra assertion to verify the local providers were actually removed.
> 2. It is reassigning the **provs** variable with Security.getProviders(). This will start adding/removing some of the system providers, in addition to the local providers, which it is not the test intent.
> 3. Adding othervm flag to run in isolation.
>
> Test runs in tier2
Fernando Guallini has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
- added brackets, and refactor a comment and an exception message
- Regtest java/security/Security/SynchronizedAccess.java is incorrect.
-------------
Changes: https://git.openjdk.org/jdk/pull/19480/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19480&range=03
Stats: 92 lines in 1 file changed: 55 ins; 4 del; 33 mod
Patch: https://git.openjdk.org/jdk/pull/19480.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/19480/head:pull/19480
PR: https://git.openjdk.org/jdk/pull/19480
More information about the security-dev
mailing list