RFR: 8330842: Support AES CBC with Ciphertext Stealing (CTS) in SunPKCS11 [v6]

Martin Balao mbalao at openjdk.org
Thu Jun 6 23:20:13 UTC 2024


On Thu, 6 Jun 2024 22:22:06 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Francisco Ferrari Bihurriet has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Apply code-review suggestion
>>   
>>   Co-authored-by: Francisco Ferrari <fferrari at redhat.com>
>>   Co-authored-by: Martin Balao <mbalao at redhat.com>
>
> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Cipher.java line 1076:
> 
>> 1074:                         outOfs += k;
>> 1075:                         outLen -= k;
>> 1076:                     }
> 
> Why not put this block into the else block starting at line 1098 below?

Ok.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18898#discussion_r1630383900



More information about the security-dev mailing list