RFR: 8333477: Delete extra empty spaces in Makefiles [v2]

SendaoYan syan at openjdk.org
Fri Jun 7 13:04:18 UTC 2024


On Fri, 7 Jun 2024 12:53:46 GMT, Chen Liang <liach at openjdk.org> wrote:

>> No, it's an extra newline. A file should end with a newline but one is enough.
>
> As confusing as they are, unfortunately GitHub UI does not render extra trailing newlines. This is the only one I could find with grepWin.

I find the extra trailing newlines through below shell command:

for i in `find . -iname "Makefile*" | sed "/./build/d"` ; do tail -n 2 $i | grep -c "^$" | grep -q "^1$" ; if [[ 0 -eq $? ]] ; then echo $i ; fi ; done


There are only two files has been found:

./test/jdk/java/rmi/reliability/benchmark/bench/rmi/Makefile
./test/jdk/java/rmi/reliability/benchmark/bench/Makefile

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19537#discussion_r1631168243



More information about the security-dev mailing list