RFR: 8333867: SHA3 performance can be improved

Ferenc Rakoczi duke at openjdk.org
Tue Jun 11 17:33:12 UTC 2024


On Tue, 11 Jun 2024 15:53:33 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Oh, and about the length: buffer is allocated in the constructor of the parent class (DigestBase) like this:
>>   buffer = new byte[blockSize];
>> Here blockSize is one of { 72, 104, 136, 144, 168 }, so divisible by 8.
>> buffer.length was used before probably because blockSize was declared private in DigestBase. I made it protected, because in my opinion it is easier to read the code this way.
>
> Thank you for explanation.
> 
> An other question. Is any other use of `longBuf` array after `implCompress0()` call which load values from it? Because Intrinsic code will not update it.

There is no other use.. That array is there for the sole purpose of  holding the input as a long array before it gets xor-ed into the state.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19632#discussion_r1635252483



More information about the security-dev mailing list