RFR: 8333364: Minor cleanup could be done in com.sun.crypto.provider

Valerie Peng valeriep at openjdk.org
Tue Jun 11 20:06:14 UTC 2024


On Tue, 4 Jun 2024 02:32:31 GMT, Mark Powers <mpowers at openjdk.org> wrote:

> https://bugs.openjdk.org/browse/JDK-8333364

src/java.base/share/classes/com/sun/crypto/provider/RSACipher.java line 276:

> 274:         outputSize = n;
> 275:         bufOfs = 0;
> 276:         if (Objects.equals(paddingType, PAD_NONE)) {

Not sure if this is necessary, with the current impl, `paddingType` is always assigned with one of internal PAD_XXX constants. Did I miss something?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19535#discussion_r1635418496



More information about the security-dev mailing list