RFR: 8333364: Minor cleanup could be done in com.sun.crypto.provider

Valerie Peng valeriep at openjdk.org
Wed Jun 12 03:36:16 UTC 2024


On Tue, 4 Jun 2024 02:32:31 GMT, Mark Powers <mpowers at openjdk.org> wrote:

> https://bugs.openjdk.org/browse/JDK-8333364

src/java.base/share/classes/com/sun/crypto/provider/CipherCore.java line 874:

> 872:         int len = Math.addExact(buffered, inputLen);
> 873:         // calculate padding length
> 874:         int totalLen = len;

Well, personally, I'd prefer to replace `len` with `totalLen`, less changes overall and better naming matching the comment on line 871.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19535#discussion_r1635768389



More information about the security-dev mailing list