RFR: 8330217: Spurious warning from jarsigner -verify when keystore with intermediate CA is used
Weijun Wang
weijun at openjdk.org
Thu Jun 13 14:06:26 UTC 2024
There is an error in `jarsigner` on the "This JAR contains signed entries that aren't signed by alias in this keystore" warning. The exit code is determined by [`notSignedByAlias`](https://github.com/openjdk/jdk/blob/0a60b0f99efb38d2cc97f3862ef95a0d26ba49a7/src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java#L344) but the warning message is controlled by [`allAliasesFound`](https://github.com/openjdk/jdk/blob/0a60b0f99efb38d2cc97f3862ef95a0d26ba49a7/src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java#L1183).
Also, inside the `inKeyStoreForOneSigner()` method, all certificates in a cert chain are used to determine whether the signer is in a keystore and if any is inside the JAR file is treated as being signed by an alias in this keystore. In fact, only the end-entity certificate (the first one in the chain) should be checked.
After the fix, the `allAliasesFound` field and the `SOME_ALIASES_NOT_FOUND` constant are useless and can be removed.
-------------
Commit messages:
- the fix
Changes: https://git.openjdk.org/jdk/pull/19701/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19701&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8330217
Stats: 144 lines in 4 files changed: 120 ins; 11 del; 13 mod
Patch: https://git.openjdk.org/jdk/pull/19701.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/19701/head:pull/19701
PR: https://git.openjdk.org/jdk/pull/19701
More information about the security-dev
mailing list