RFR: 8333364: Minor cleanup could be done in com.sun.crypto.provider [v3]

Mark Powers mpowers at openjdk.org
Thu Jun 13 20:56:52 UTC 2024


On Wed, 12 Jun 2024 04:15:44 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Mark Powers has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   join two lines
>
> src/java.base/share/classes/com/sun/crypto/provider/CipherCore.java line 969:
> 
>> 967:     private int finalNoPadding(byte[] in, int inOfs, byte[] out, int outOfs,
>> 968:                                int len)
>> 969:         throws IllegalBlockSizeException {
> 
> Hmm, is ShortBufferException still needed for `prepareInputBuffer(...)` and `fillOutputBuffer(...)`?

Not needed by `fillOutputBuffer(..)` but needed by `prepareInputBuffer(...)`.
IJ was right.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19535#discussion_r1638921875



More information about the security-dev mailing list