RFR: 8333583: Crypto-XDH.generateSecret regression after JDK-8329538 [v3]

[Vladimir Kozlov]

On Mon, 17 Jun 2024 18:51:33 GMT, Volodymyr Paprotski <duke at openjdk.org> wrote:

> Actually, the other way around; reducePositive is now an unconditionally executed for both pure java and the intrinsic paths. 

Looking on `MontgomeryIntegerPolynomialP256.java` the code in `multImpl() + reducePositive()` is similar to original `mult()` except new additional code at the end of `multImpl()`. Now you intrinsify only `multImpl()`. Looks like `reducePositive()`is not included into intrinsic and will be normally JIT compiled (hopeful inlined when JIT compiling `mult()`. Then what do you mean in above statement?

Also you did not change assembler for intrinsic but you changed corresponding Java code (`multImpl()`).  How it works?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19728#issuecomment-2174250094