RFR: 8334670: SSLSocketOutputRecord buffer miscalculation
Daniel Jeliński
djelinski at openjdk.org
Tue Jun 25 19:46:10 UTC 2024
On Tue, 25 Jun 2024 18:26:40 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:
>> src/java.base/share/classes/sun/security/ssl/SSLSocketOutputRecord.java line 171:
>>
>>> 169: for (int limit = (offset + length); offset < limit;) {
>>> 170:
>>> 171: int remains = (limit - offset) + (count - position);
>>
>> Suggestion:
>>
>> int remains = (limit - offset);
>
> I tried this and it caused a lockup in one of the tests. I see why your think this is the right change, but it isn't proving out in the testing
That's very interesting! Which test was it? Was it with or without #19465?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19862#discussion_r1653464830
More information about the security-dev
mailing list