RFR: 8334562: Automate com/sun/security/auth/callback/TextCallbackHandler/Default.java test

Weijun Wang weijun at openjdk.org
Wed Jun 26 16:14:11 UTC 2024


On Wed, 26 Jun 2024 15:23:47 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> The following test: **com/sun/security/auth/callback/TextCallbackHandler/Default.java** is currently marked to be run manually because user inputs are required in the console, but instead it can be automated by providing a custom inputStream to System.in in the actual test to simulate sequential user input.
>> 
>> In addition, this patch is removing the test from the problemList as it passes, and from manual test list.
>
> test/jdk/com/sun/security/auth/callback/TextCallbackHandler/Default.java line 80:
> 
>> 78:         pipedOut.write("-1\n".getBytes());
>> 79:         pipedOut.flush();
>> 80:         textHandler.handle(new Callback[]{callback});
> 
> Can you handle 2 `Callback`s in a single `handle` call?

Try if this class works for you. https://github.com/openjdk/jdk/blob/45a616a891e4a4b0e77b1f2fa040522f4a99d172/test/jdk/sun/security/tools/keytool/KeyToolTest.java#L1885

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19790#discussion_r1655156432



More information about the security-dev mailing list