RFR: 8312444: Unused parameter 'defval' in SocketPermission.initEphemeralPorts could be removed

Guoxiong Li gli at openjdk.org
Sat Mar 2 08:57:56 UTC 2024


On Fri, 1 Mar 2024 17:35:35 GMT, Korov <duke at openjdk.org> wrote:

> Removing unused parameter `defval` in `SocketPermission.initEphemeralPorts`, so the variable `PRIV_PORT_MAX` and `DEF_EPH_LOW` unused too.
> 
> Removing unused parameter `cname` in `SocketPermission.authorizedIPv4` and `SocketPermission.authorizedIPv6`.
> 
> Parameter 'action' must be not empty so `a.length > 0`, the check `a.length - 1 < 0` can be removed.

The patch looks good. But the title of this issue may need to be adjusted, because you not only change the `SocketPermission.initEphemeralPorts` but also change other code. Or you can separate the unrelated code to another issue.

-------------

Marked as reviewed by gli (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18086#pullrequestreview-1912616977



More information about the security-dev mailing list