RFR: 8312444: Delete unused parameters and variables in SocketPermission

Guoxiong Li gli at openjdk.org
Sat Mar 2 11:37:51 UTC 2024


On Sat, 2 Mar 2024 08:54:44 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Removing unused parameter `defval` in `SocketPermission.initEphemeralPorts`, so the variable `PRIV_PORT_MAX` and `DEF_EPH_LOW` unused too.
>> 
>> Removing unused parameter `cname` in `SocketPermission.authorizedIPv4` and `SocketPermission.authorizedIPv6`.
>> 
>> Parameter 'action' must be not empty so `a.length > 0`, the check `a.length - 1 < 0` can be removed.
>
> The patch looks good. But the title of this issue may need to be adjusted, because you not only change the `SocketPermission.initEphemeralPorts` but also change other code. Or you can separate the unrelated code to another issue.

> Hello @lgxbslgx , the title has been changed, Can you check if it's suitable?

Seems good. If nobody disagrees such mixed patch, I will help you change the title and content of the issue.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18086#issuecomment-1974771937



More information about the security-dev mailing list