RFR: 8323624: ProviderList.ServiceList does not need to be a list [v3]

Sean Mullan mullan at openjdk.org
Tue Mar 5 14:26:47 UTC 2024


On Fri, 12 Jan 2024 18:06:33 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Re-implement it as an `Iterator` to make sure it can only be iterated once and make debugger happy.
>> 
>> No regression, just a refactoring.
>
> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   use consistent names

src/java.base/share/classes/sun/security/jca/ProviderList.java line 429:

> 427:      * Not thread safe.
> 428:      */
> 429:     private final class ServiceList implements Iterator<Service> {

Wouldn't it make more sense to change the name to `ServiceIterator`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17381#discussion_r1512913289



More information about the security-dev mailing list