RFR: 8327461: KeyStore getEntry is not thread-safe [v4]

Hai-May Chao hchao at openjdk.org
Fri Mar 8 08:27:53 UTC 2024


On Fri, 8 Mar 2024 08:22:21 GMT, Hai-May Chao <hchao at openjdk.org> wrote:

>> Change was made to engineGetEntry() in PKCS12KeyStore to extract the key and certificate chain from Entry only once. This is because the entry may get updated between engineGetKey() and engineGetCertificateChain() which causes inconsistent result. A new test was added to assess and manipulate PKCS12KeyStore with read and write operations concurrently from multiple threads. Thanks!
>
> Hai-May Chao has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update engineDeleteEntry

engineEntryInstanceOf has only one direct access to the entries map. After obtaining the entry object, its type is checked against the specified entryClass, which do not involve accessing the entries map again.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18156#issuecomment-1985254087



More information about the security-dev mailing list