RFR: 8327461: KeyStore getEntry is not thread-safe [v5]

Daniel Jeliński djelinski at openjdk.org
Fri Mar 8 09:24:54 UTC 2024


On Fri, 8 Mar 2024 09:22:13 GMT, Hai-May Chao <hchao at openjdk.org> wrote:

>> Change was made to engineGetEntry() in PKCS12KeyStore to extract the key and certificate chain from Entry only once. This is because the entry may get updated between engineGetKey() and engineGetCertificateChain() which causes inconsistent result. A new test was added to assess and manipulate PKCS12KeyStore with read and write operations concurrently from multiple threads. Thanks!
>
> Hai-May Chao has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove unneeded checks in engineGetEntry

LGTM. Thanks!

-------------

Marked as reviewed by djelinski (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18156#pullrequestreview-1924445608



More information about the security-dev mailing list