RFR: 8327461: KeyStore getEntry is not thread-safe [v6]

Weijun Wang weijun at openjdk.org
Fri Mar 8 23:41:53 UTC 2024


On Fri, 8 Mar 2024 23:30:28 GMT, Hai-May Chao <hchao at openjdk.org> wrote:

>> Because `null` will fail all three `instanceof` checks.
>
> I'd like to keep the check here for good practice and following the API doc, instead of letting further instanceof operation fails. Thanks.

Sure, you can keep it. But please note that there was no null check before your change.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18156#discussion_r1518413455



More information about the security-dev mailing list