RFR: 8327818: Implement Kerberos debug with sun.security.util.Debug [v4]

[Weijun Wang]

On Thu, 14 Mar 2024 19:18:16 GMT, Mark Powers <mpowers at openjdk.org> wrote:

>> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   just use true
>
> src/java.security.jgss/share/classes/sun/security/jgss/spnego/SpNegoToken.java line 30:
> 
>> 28: import org.ietf.jgss.GSSException;
>> 29: import sun.security.jgss.GSSToken;
>> 30: import sun.security.util.Debug;
> 
> Is this really needed?

Will remove it.

> src/java.security.jgss/share/classes/sun/security/krb5/internal/KerberosTime.java line 36:
> 
>> 34: import sun.security.krb5.Config;
>> 35: import sun.security.krb5.KrbException;
>> 36: import sun.security.util.Debug;
> 
> Needed?

No. Sorry.

> src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/crc32.java line 33:
> 
>> 31: package sun.security.krb5.internal.crypto;
>> 32: 
>> 33: import sun.security.krb5.internal.Krb5;
> 
> It's not obvious to me why this import is needed.

Not needed. Will remove.

> src/jdk.security.auth/share/classes/com/sun/security/auth/module/Krb5LoginModule.java line 1015:
> 
>> 1013:         } catch (Exception e) {
>> 1014:             lcreds = null;
>> 1015:             if (debug != null)
> 
> Might want to add curley braces here and elsewhere.

Can I leave them unchanged? I don't know an efficient way to search for all places.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18199#discussion_r1525446228
PR Review Comment: https://git.openjdk.org/jdk/pull/18199#discussion_r1525446664
PR Review Comment: https://git.openjdk.org/jdk/pull/18199#discussion_r1525450527
PR Review Comment: https://git.openjdk.org/jdk/pull/18199#discussion_r1525448518