RFR: 8328957: Update PKCS11Test.java to not use hardcoded path

Martin Balao mbalao at openjdk.org
Tue Mar 26 16:33:21 UTC 2024


On Tue, 26 Mar 2024 14:02:27 GMT, Matthew Donovan <mdonovan at openjdk.org> wrote:

> When resolving the location of the NSS library, the code appended a hard-coded path: `/nss/lib`. This makes it difficult for a person to specify the library when it is installed in a location such as `/usr/lib64`. 
> 
> In this PR, I removed the hard-coded path and updated the code to search the specified path for the nss library file, softokn3.

Hi @mpdonova ,

Thanks for contributing this fix. I've seen in java.nio.file.Files::find doc an implementation note saying that it should be used in a try-with-resource fashion to close the stream and any open directories. Should we consider this?

One more question. The ".orElse(path).getParent()" code path, what case is it intended for? I wonder in which cases this is expected to succeed.

Martin.-

-------------

PR Review: https://git.openjdk.org/jdk/pull/18488#pullrequestreview-1961059503



More information about the security-dev mailing list