RFR: 8329213: Better validation for com.sun.security.ocsp.useget option [v2]

[Aleksey Shipilev]

On Thu, 28 Mar 2024 18:19:44 GMT, Sean Mullan <mullan at openjdk.org> wrote:

> Can you also add to the RN that any value other than "false" (case-insensitive) defaults to "true".

Amended the existing [RN](https://bugs.openjdk.org/browse/JDK-8329111).

> src/java.base/share/classes/sun/security/action/GetPropertyAction.java line 235:
> 
>> 233:      * @param dbg a Debug object, if null no debug messages will be sent
>> 234:      *
>> 235:      * @return an boolean value corresponding to the value in the System property.
> 
> s/an/a/

Done.

> src/java.base/share/classes/sun/security/action/GetPropertyAction.java line 239:
> 
>> 237:      *      will be returned.
>> 238:      */
>> 239:     public static boolean privilegedGetBooleanProp(String prop, boolean def, Debug dbg) {
> 
> It probably makes more sense to put this method in the `GetBooleanAction` class.

I thought so first too, but decided that `GetPropertyAction` is a better place for it, because it needs the generic `privilegedGetProperty`. It is also adjacent to `privilegedGetTimeoutProp` that returns `int`. Makes sense?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18525#issuecomment-2025856087
PR Review Comment: https://git.openjdk.org/jdk/pull/18525#discussion_r1543436079
PR Review Comment: https://git.openjdk.org/jdk/pull/18525#discussion_r1543436216