RFR: 8331008: KDF Implementation [v2]

Sean Mullan mullan at openjdk.org
Thu May 9 17:31:56 UTC 2024


On Thu, 9 May 2024 16:45:02 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Kevin Driver has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
>> 
>>  - move the test to the correct directory, which was already created
>>  - tests passing
>>  - start deriveKey
>>  - remove SHA224 mentions
>>  - remove SHA224 mentions
>>  - additional helper methods
>>  - parameter validation for impl
>>  - parameter validation for impl
>>  - initial commit into open
>
> src/java.base/share/classes/javax/crypto/KDFSpi.java line 107:
> 
>> 105:      *     if the key derivation implementation cannot support additional calls to
>> 106:      *     {@code deriveData } or if all {@code DerivationParameterSpec} objects have been
>> 107:      *     processed.
> 
> What kind of exception will be thrown if the derived key of this KDF is not extractable?

Sounds like we may need a new exception class, like `DerivationException`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1595761402



More information about the security-dev mailing list