RFR: 8331008: KDF Implementation [v3]

[Kevin Driver]

On Thu, 9 May 2024 20:31:30 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   some code review comments
>
> src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java line 223:
> 
>> 221:         // A switch would be nicer, but we may need to backport this before JDK 17
>> 222:         // Also, JEP 305 came out in JDK 14, so we can't declare a variable in instanceof either
>> 223:         if (kdfParameterSpec instanceof HKDFParameterSpec.Extract) {
> 
> `kdfParameterSpec instanceof HKDFParameterSpec.Extract anExtract`.

Please read the comment. Avoiding declaring a variable during an `instanceof` check was intentional, since this will aid with backporting. I'm not sure how far back we'll have to port this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1595981033