RFR: 8329538: Accelerate P256 on x86_64 using Montgomery intrinsic [v7]

[Volodymyr Paprotski]

On Thu, 9 May 2024 23:36:03 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

>> Volodymyr Paprotski has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   whitespace
>
> src/java.base/share/classes/sun/security/ec/ECOperations.java line 701:
> 
>> 699:                         if (!m.equals(v)) {
>> 700:                             java.util.HexFormat hex = java.util.HexFormat.of();
>> 701:                             throw new RuntimeException();
> 
> I think your cleanup went to far. You should have some message saying they are not equal and if you don't want to print hex, remove getting an instance.

I put the message back.. I removed it 'half'-intentionally; Was comparing against the original version and it didn't have  any details, thought maybe should follow suit. But I did find this message helpful, so its back.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18583#discussion_r1596116606