RFR: 8331008: KDF Implementation [v4]
Sean Mullan
mullan at openjdk.org
Fri May 10 12:52:23 UTC 2024
On Thu, 9 May 2024 20:18:10 GMT, Kevin Driver <kdriver at openjdk.org> wrote:
>> src/java.base/share/classes/javax/crypto/KDF.java line 115:
>>
>>> 113: * {@code getInstance} calls that created this {@code KeyDerivation} object.
>>> 114: *
>>> 115: * @return the algorithm name of this {@code KeyDerivation} object.
>>
>> Nit: remove period, sentences that don't start with a capital letter and don't have a following sentence should not have period at end
>
> Done. Please resolve if satisfied.
You missed a few in the `@throws` clauses.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1596712502
More information about the security-dev
mailing list