RFR: 8331008: KDF Implementation (Preview) [v3]
Kevin Driver
kdriver at openjdk.org
Fri May 10 18:43:34 UTC 2024
On Thu, 9 May 2024 20:33:57 GMT, Weijun Wang <weijun at openjdk.org> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
>>
>> some code review comments
>
> src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java line 365:
>
>> 363: // Calculate the number of rounds of HMAC that are needed to
>> 364: // meet the requested data. Then set up the buffers we will need.
>> 365: hmacObj.init(prk);
>
> prk size must be checked somewhere.
see commit: https://github.com/openjdk/jdk/pull/18924/commits/e1b63f3a90ea5583ac86687ddd89bf9fda7d2613
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1597088541
More information about the security-dev
mailing list