RFR: 8331008: KDF Implementation (Preview) [v3]
Kevin Driver
kdriver at openjdk.org
Fri May 10 19:03:07 UTC 2024
On Thu, 9 May 2024 21:21:55 GMT, Weijun Wang <weijun at openjdk.org> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
>>
>> some code review comments
>
> src/java.base/share/classes/javax/crypto/KDF.java line 1:
>
>> 1: /*
>
> Delayed provider selection is not implemented yet. See `KeyAgreement` and how its `getInstance(alg)` returns an object that contains a `serviceIterator` and how its `chooseProvider` method choose one from the iterator that supports the user-provided key (here, it's a `KDFParameterSpec`).
>
> You should probably create a test to ensure it.
see commit: https://github.com/openjdk/jdk/pull/18924/commits/d4faac743c5115a4a8b82e759a8a935cd9faa25b
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1597123888
More information about the security-dev
mailing list