RFR: 8331008: KDF Implementation (Preview) [v18]

Kevin Driver kdriver at openjdk.org
Fri May 10 20:59:07 UTC 2024


On Thu, 9 May 2024 15:01:24 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   a start on the preview wire on/off
>
> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 47:
> 
>> 45:     final class Builder {
>> 46: 
>> 47:         Extract extract = null;
> 
> No need to store an `extract` field. Just create one and return it in `extractOnly`.

This field is required for checks in other functions.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1597222648



More information about the security-dev mailing list