RFR: 8331008: KDF Implementation (Preview) [v29]

[Kevin Driver]

On Thu, 9 May 2024 13:01:16 GMT, Sibabrata Sahoo <ssahoo at openjdk.org> wrote:

>> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   code review comment re:returning null from derives
>
> src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java line 148:
> 
>> 146:         }
>> 147: 
>> 148:         return null;
> 
> Should it throw exception instead of null? Also it will never reach here.

An exception is better, yes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1598661624