RFR: 8331008: KDF Implementation (Preview) [v32]

Kevin Driver kdriver at openjdk.org
Mon May 13 16:20:08 UTC 2024


On Thu, 9 May 2024 15:18:43 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove (now) extraneous null-check
>
> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 352:
> 
>> 350:          */
>> 351:         private ExtractExpand(Extract ext, byte[] info, int length) {
>> 352:             if (ext == null) {
> 
> Could this happen?

after the addition of earlier checks, it cannot. removed in: b0ac8d7a604

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1598732110



More information about the security-dev mailing list