RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v28]

Sean Mullan mullan at openjdk.org
Mon May 13 19:07:14 UTC 2024


On Mon, 13 May 2024 18:56:25 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 332:
>> 
>>> 330:          * @return the optional context and application specific information
>>> 331:          */
>>> 332:         public byte[] info() {
>> 
>> I think the API docs will need to say that it returns a copy of the context/info, don't want readers to assume that an Expand object is mutable by way to modifying the byte[].
>
> see: 05604208333

I agree. Suggest: "Each invocation of this method returns a copy of the byte array."

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1598927266



More information about the security-dev mailing list