RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v34]

Sean Mullan mullan at openjdk.org
Mon May 13 19:40:23 UTC 2024


On Mon, 13 May 2024 15:53:45 GMT, Kevin Driver <kdriver at openjdk.org> wrote:

>> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 213:
>> 
>>> 211:     /**
>>> 212:      * Static helper-method that may be used to initialize an {@code ExtractExpand} object
>>> 213:      * <p>
>> 
>> Do we really need this method since user can already call `extract()....andExpand()`?
>> 
>> If this method is removed, then we don't need to check null for `ext` in `new ExtractExpand`.
>> 
>> Or, you want to create one `Extract` object and then reuse it multiple times?
>
> It makes sense to leave it for consistency's sake, IMO.

I think we should remove it. At least for this first API revision, let's make the API simpler and give users one way to create `ExtractExpand` params.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1598988291



More information about the security-dev mailing list