RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v28]
Weijun Wang
weijun at openjdk.org
Mon May 13 21:05:41 UTC 2024
On Mon, 13 May 2024 09:31:53 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
>>
>> re-enable preview annotations
>
> src/java.base/share/classes/javax/crypto/KDFSpi.java line 41:
>
>> 39: * All the abstract methods in this class must be implemented by each
>> 40: * cryptographic service provider who wishes to supply the implementation of a
>> 41: * particular key derivation algorithm.
>
> As a general point here, this doesn't link to anything that explains what any of this means. If I implement KDFSpi then what do I do with it? It's not referenced by anything else in the API.
+1. Especially, describe what constructor an implementation should provide, it should be public, it should have an argument, it should throw some exceptions in some cases.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1599073316
More information about the security-dev
mailing list