RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v33]

[Weijun Wang]

On Mon, 13 May 2024 17:37:38 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update @return statement
>
> src/java.base/share/classes/javax/crypto/KDFSpi.java line 72:
> 
>> 70:     protected KDFSpi(AlgorithmParameterSpec algParameterSpec)
>> 71:         throws InvalidAlgorithmParameterException {
>> 72:         this.algorithmParameterSpec = algParameterSpec;
> 
> Related to above comment about not storing the params, make this ctor do nothing.

Or maybe just remove it? If you keep the constructor here, you might expect implementations always calling `super(alg)`, but it actually does nothing. Then people will not call it, and even if one day you add some code here they will not get executed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1599076583