RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v3]

Kevin Driver kdriver at openjdk.org
Mon May 13 21:59:12 UTC 2024


On Thu, 9 May 2024 21:28:47 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   some code review comments
>
> test/jdk/com/sun/crypto/provider/KDF/TestHkdf.java line 233:
> 
>> 231:      * are the same.
>> 232:      */
>> 233:     private static boolean compareKeyAndData(Key outKey, byte[] outData,
> 
> We have `Asserts.assertEqualsByteArray` in `test/lib`.

Will revisit, but low priority for now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1599132904



More information about the security-dev mailing list