RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v34]

Kevin Driver kdriver at openjdk.org
Mon May 13 22:37:09 UTC 2024


On Mon, 13 May 2024 20:27:46 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Kevin Driver has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   code review comments
>
> src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java line 237:
> 
>> 235:             } catch (InvalidKeyException ike) {
>> 236:                 throw new InvalidParameterSpecException(
>> 237:                     "Issue encountered when combining ikm or salt values into single keys");
> 
> add cause (ike) to exception.

What is the preferred mechanism for this? This type does not have a Throwable parameter, so I can't pass `ike` to the ctor.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1599165619



More information about the security-dev mailing list